[FEATURE] Recurrence rule generation#560
Open
amnuts wants to merge 6 commits intomarkuspoerschke:2.xfrom
Open
Conversation
amnuts
changed the title
PHP 7.4 doesn't support union or mixed types. But Psalm complains there are no types on 8.x tests. So now where you could pass in a single value or an array of the values, you're forced to always pass in an array.
amnuts
changed the title
Author
|
@markuspoerschke, any feedback on this one? Not what you were wanting? I appreciate that the hacktoberfest label was added to a ticket that was a few years old (wish I had noticed that before starting 😁), so possibly you've got some other mechanism in place that I didn't spot. |
|
Trying to port a 0.11.x implementation to 2.x that heavily relied on recurrence rules. Getting this merged would be sweet. Anything I could help with? |
|
@markuspoerschke Is there a reason why this PR is not being accepted? It looks really nice, I'm looking for this functionality as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to create recurrence rules - fixes #189.
Tests included for the components.
example4.phpgives a small example of adding a recurrence rule.